Submodule links not recognized by web ui when SSH_DOMAIN is used

[MartB]

• Gitea version (or commit ref): 1.12.4

Description

When using a different domain for ssh access, submodules links are not correct within the gitea web interface.

Having a .gitmodules set up like this:

...
url = ssh://gitea@ssh.martb.eu/....

and a gitea instance set up with https://git.martb.eu/ with its SSH_DOMAIN set to ssh.martb.eu leads to ssh. being used as a http href instead of gitea translating it to the "known" git. domain.

Affected lines

gitea/templates/repo/view_list.tmpl

Line 50 in 332dbe7

{{$refURL := $commit.RefURL AppUrl $.Repository.FullName}}

Screenshots

[MartB]

I just noticed that this is a duplicate of #9756, any news regarding this?

[6543]

@MartB I think it is similar or related ... throu I think we can keep both open

[6543]

there was done some work on submodule recognizion in the master branch some time ago , so it has to be checked if this is still present on master ...

[zeripath]

@MartB could you confirm that this is present on try?

[mrsdizzie]

@zeripath I don't think you can check this on try because it doesn't use a different domain name for SSH_HOST and DOMAIN

The issue is that we use AppUrl as the urlPrefix value here:

gitea/modules/git/submodule.go

Line 42 in ad2bf37

func getRefURL(refURL, urlPrefix, repoFullName string) string {

So this will never match:

gitea/modules/git/submodule.go

Line 79 in ad2bf37

if urlPrefixHostname == refHostname {

Because they use a different hostname in the submodule file that matches the separate hostname they have used for SSH_DOMAIN. So our logic thinks this is hosted elsewhere but really it is still the same copy of Gitea just with a different hostname for SSH_DOMAIN.

I think the issue here is that we need to also check if the hostname found in the submodule file matches the SSH_DOMAIN value and then create the link with the AppUrl instead.

[MartB]

Thanks for looking into that!