Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]When view commit detail it returns 500 #11869

Closed
2 of 8 tasks
L0veSunshine opened this issue Jun 12, 2020 · 1 comment · Fixed by #11870
Closed
2 of 8 tasks

[BUG]When view commit detail it returns 500 #11869

L0veSunshine opened this issue Jun 12, 2020 · 1 comment · Fixed by #11870

Comments

@L0veSunshine
Copy link
Contributor

L0veSunshine commented Jun 12, 2020 •
edited
Loading

Description

After my test. I suspect this issue may be caused by this pr (#11847).
This issue is same to #11868
Please have a review.

Screenshots

image
@mrsdizzie
Copy link
Member

This is
2020/06/12 12:27:54 ...uters/repo/commit.go:317:Diff() [E] commit.GetTagName: exit status 128 - fatal: No names found, cannot describe anything.

From #11846

mrsdizzie added a commit to mrsdizzie/gitea that referenced this issue Jun 12, 2020
@mrsdizzie
Fix 500 error on repos with no tags
f936249 
 go-gitea#11846 Introduced feature to show exact tag on commit view. However if a repo has no tags at all git prints out a separate and unhandled error " No names found, cannot describe anything."

 Adding --always to the command makes it always use the error in the style of "fatal: no tag exactly matches" even if there are no tags at all.

 Fixes go-gitea#11869
 Fixes go-gitea#11868
@mrsdizzie mrsdizzie mentioned this issue Jun 12, 2020
Merged
techknowlogick pushed a commit that referenced this issue Jun 12, 2020
@mrsdizzie
Fix 500 error on repos with no tags (#11870)
d729d68 
#11846 Introduced feature to show exact tag on commit view. However if a repo has no tags at all git prints out a separate and unhandled error " No names found, cannot describe anything."

 Adding --always to the command makes it always use the error in the style of "fatal: no tag exactly matches" even if there are no tags at all.

 Fixes #11869
 Fixes #11868
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@mrsdizzie
Fix 500 error on repos with no tags (go-gitea#11870)
aa894f2 
go-gitea#11846 Introduced feature to show exact tag on commit view. However if a repo has no tags at all git prints out a separate and unhandled error " No names found, cannot describe anything."

 Adding --always to the command makes it always use the error in the style of "fatal: no tag exactly matches" even if there are no tags at all.

 Fixes go-gitea#11869
 Fixes go-gitea#11868
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix 500 error on repos with no tags mrsdizzie/gitea
2 participants
@mrsdizzie @L0veSunshine