Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] commits history comment on PR show unrelated after merge #11536

Closed
6543 opened this issue May 21, 2020 · 4 comments · Fixed by #11555
Closed

[Bug] commits history comment on PR show unrelated after merge #11536

6543 opened this issue May 21, 2020 · 4 comments · Fixed by #11555
Labels
Milestone

Comments

@6543
Copy link
Member

6543 commented May 21, 2020

a merge will display all comits

what I expect: only chow the merge commit

demo: https://gitea.com/gitea/go-sdk/pulls/273#issuecomment-113383

function introduced in #11167

@a1012112796

This comment has been minimized.

@a1012112796
Copy link
Member

I have no idea why... :(

@a1012112796
Copy link
Member

I found the reason now, if use merge like this style, commit B can't be skipped. But I have no idea how to find it....
image

@6543
Copy link
Member Author

6543 commented May 21, 2020

@a1012112796 if a commit have more than 1 parent just show that comment without the parents?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants