Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sugget show commits from old to new in list #11377

Closed
7 tasks
a1012112796 opened this issue May 11, 2020 · 1 comment
Closed
7 tasks

sugget show commits from old to new in list #11377

a1012112796 opened this issue May 11, 2020 · 1 comment
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.

Comments

@a1012112796
Copy link
Member

  • Gitea version (or commit ref):
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

Hello,Currently, the new commit comes before the old one in the pr commits list.I don't like this style, suggest displaying it in the old to new order, which is the same as github. Thanks
compare view:
gitea:

image

github:

image

maybe we can use this way to change, but I'm not confirm this way is right.

diff --git a/modules/git/repo.go b/modules/git/repo.go
index 644ff0928..491a97889 100644
--- a/modules/git/repo.go
+++ b/modules/git/repo.go
@@ -65,7 +65,7 @@ func (repo *Repository) parsePrettyFormatLogToList(logs []byte) (*list.List, err
                if err != nil {
                        return nil, err
                }
-               l.PushBack(commit)
+               l.PushFront(commit)
        }

        return l, nil
@techknowlogick techknowlogick added type/proposal The new feature has not been accepted yet but needs to be discussed first. topic/ui Change the appearance of the Gitea UI labels May 14, 2020
@a1012112796
Copy link
Member Author

stale?

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

No branches or pull requests

2 participants