Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to submodule hosted by the same server via ssh missing port/prefix #11002

Closed
1 of 7 tasks
bwiethof opened this issue Apr 7, 2020 · 2 comments · Fixed by #11098
Closed
1 of 7 tasks

Link to submodule hosted by the same server via ssh missing port/prefix #11002

bwiethof opened this issue Apr 7, 2020 · 2 comments · Fixed by #11098
Labels
type/bug
Milestone
1.11.5

Comments

@bwiethof
Copy link

bwiethof commented Apr 7, 2020

  • Gitea version (or commit ref): 1.10.0
  • Git version:
  • Operating system:
  • Database (use [x]):
    • PostgreSQL
    • MySQL
    • MSSQL
    • SQLite
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

If a submodule is hosted by the same server as the parent repository and is linked via ssh, the link is missing the prefix/port.
In case of http linking, the created link is valid.

The screenshots showing the link for http in the left corner. With ssh the port/prefix is missing.

Screenshots

http
ssh
@yoyoyonas
Copy link

I can confirm this for v1.11.3.

@MatthieuParis
Copy link

Same thing for v.1.11.4.
Seems to be linked to issue #2882

zeripath added a commit to zeripath/gitea that referenced this issue Apr 16, 2020
@zeripath
Fix submodule paths when AppSubUrl is not root
42bb86d 
Fix go-gitea#11002

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Apr 16, 2020
Merged
zeripath added a commit that referenced this issue Apr 22, 2020
@zeripath
Fix submodule paths when AppSubUrl is not root (#11098)
4ee70a9 
Fix submodule paths when AppSubUrl is not root

Fix #11002

Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath added a commit to zeripath/gitea that referenced this issue Apr 22, 2020
@zeripath
Fix submodule paths when AppSubUrl is not root (go-gitea#11098)
9094dac 
Backport go-gitea#11098

Fix go-gitea#11002

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Apr 22, 2020
Merged
@lafriks lafriks added this to the 1.11.5 milestone Apr 22, 2020
zeripath added a commit that referenced this issue Apr 22, 2020
@zeripath
Fix submodule paths when AppSubUrl is not root (#11098) (#11176)
4a6765f 
Backport #11098

Fix #11002

Signed-off-by: Andrew Thornton <art27@cantab.net>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@zeripath
Fix submodule paths when AppSubUrl is not root (go-gitea#11098)
08bbbb8 
Fix submodule paths when AppSubUrl is not root

Fix go-gitea#11002

Signed-off-by: Andrew Thornton <art27@cantab.net>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.11.5
Development

Successfully merging a pull request may close this issue.

Fix submodule paths when AppSubUrl is not root zeripath/gitea
5 participants
@lafriks @yoyoyonas @guillep2k @MatthieuParis @bwiethof