Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR / Issue templates do not get rendered during PR creation #10975

Closed
1 of 3 tasks
dirien opened this issue Apr 5, 2020 · 1 comment · Fixed by #11100
Closed
1 of 3 tasks

PR / Issue templates do not get rendered during PR creation #10975

dirien opened this issue Apr 5, 2020 · 1 comment · Fixed by #11100
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone
1.11.5

Comments

@dirien
Copy link

dirien commented Apr 5, 2020 •
edited
Loading

  • Gitea version (or commit ref): 1.11.3
  • Can you reproduce the bug at https://try.gitea.io:
    • Yes (provide example URL)
    • No
    • Not relevant
  • Log gist:

Description

We created pull request template in the same way it is written in the documentaton https://docs.gitea.io/en-us/issue-pull-request-templates/. That worked fine.

The only issue we see now is, that wenn yo create a Pull Request the description field is empty. Only when you click in the "Write" field the tempates get rendered. Otherwise it stays empty. So the users dont have a hint to fill it out. Worst case, no description as it is not mandatory field.

In github, it gets renderd, as soon you create the PR

Screenshots

new PR - no template rendered:
new_pr

click on Write-Field:
click_of_write
te - templates get renderd
@dirien dirien changed the title PR / Issue Templates dont get autom. rendered during PR creation. PR / Issue templates do not get rendered during PR creation Apr 5, 2020
@techknowlogick techknowlogick added type/bug topic/ui Change the appearance of the Gitea UI labels Apr 6, 2020
@6543
Copy link
Member

6543 commented Apr 6, 2020

afects current master too

@lunny lunny added this to the 1.11.5 milestone Apr 6, 2020
zeripath added a commit to zeripath/gitea that referenced this issue Apr 16, 2020
@zeripath
Refresh codemirror on show pull comment tab
2bc822f 
Fix go-gitea#10975

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath mentioned this issue Apr 16, 2020
Merged
guillep2k added a commit that referenced this issue Apr 18, 2020
@zeripath @jolheiser
@techknowlogick @guillep2k
Refresh codemirror on show pull comment tab (#11100)
731bdef 
Fix #10975

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
zeripath added a commit to zeripath/gitea that referenced this issue Apr 18, 2020
@zeripath @jolheiser
@techknowlogick @guillep2k
Refresh codemirror on show pull comment tab (go-gitea#11100)
a8f0e0f 
Fix go-gitea#10975

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
@zeripath zeripath mentioned this issue Apr 18, 2020
Merged
guillep2k added a commit that referenced this issue Apr 18, 2020
@zeripath @jolheiser
@techknowlogick @guillep2k
Refresh codemirror on show pull comment tab (#11100) (#11122)
d9875ff 
Fix #10975

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this issue Jul 31, 2020
@zeripath @jolheiser
@techknowlogick @guillep2k
Refresh codemirror on show pull comment tab (go-gitea#11100)
d3fcc83 
Fix go-gitea#10975

Signed-off-by: Andrew Thornton <art27@cantab.net>

Co-authored-by: John Olheiser <john.olheiser@gmail.com>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
1.11.5
Development

Successfully merging a pull request may close this issue.

Refresh codemirror on show pull comment tab zeripath/gitea
4 participants
@lunny @techknowlogick @6543 @dirien