-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attachment links are not human readable again #10919
Comments
The change was in #9529 and this functionality can return once #9534 is fixed. Until then, the URL pattern still works, it's just no longer exposed on the UI. 🙁 e.g. |
Ok than I'll still wait |
This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions. |
Keep until fixed? |
Is there still no fix for it? Even if I can build the readable URLs on my own, it's pretty hard for the "normal" user. I am surprised that I am the only one who is bothered by it 😄 |
I have a related issue with attachment URL. Not sure if I need to create a new ticket or this one will fix it too. Assuming, I have the gitea configured as http://192.168.1.1:1234. If I open a release page http://gitea.home/org/repo/releases, I will have 3 URLs: I would expect, the attachment URL use http://gitea.home, same as Source Code URLs. Note: if I manually enter the URL http://gitea.home/attachments/a3793480-68ed-48c9-ae70-e57e512383b2, it works. |
I've been finding this inconvenient for tools that wish to be able to download a specific release's binaries for a specific architecture (and it also makes the config files for those much harder to read, since at a glance you can't tell which version is in use). I had no idea that this was already possible, just 'secret', according to the following scheme (deduced from the messages above): |
I would also welcome more human-readable URLs. Maybe the URL matching patterns can be altered to accept any name after the UUID? That way a link can be constructed like Personally this would make my workflow of investigating Blender bug reports a lot easier. What I used to do (before moving to Gitea) was to type |
As promised in #23817, I have this made a PR to make Release Download URLs predictable. It currently follows the schema `<repo>/releases/download/<tag>/<filename>`. this already works, but it is nowhere shown in the UI or the API. The Problem is, that it is currently possible to have multiple files with the same name (why do we even allow this) for a release. I had written some Code to check, if a Release has 2 or more files with the same Name. If yes, it uses the old `attachments/<uuid>` URlL if no it uses the new fancy URL. I had also changed `<repo>/releases/download/<tag>/<filename>` to directly serve the File instead of redirecting, so people who who use automatic update checker don't end up with the `attachments/<uuid>` URL. Fixes #10919 --------- Co-authored-by: a1012112796 <1012112796@qq.com>
[x]
):Description
After upgrading to v1.11.3 release attachment links are not human-readable again and now looks like
https://gitea.example/attachments/a0023262-7abf-461d-9271-2e9f195ecebc
instead ofhttps://gitea.example/xoxys/cups-rpm/releases/download/v.1.0.0
.The text was updated successfully, but these errors were encountered: