Skip to content

Commit

Permalink
Consolidate security-check into checks-backend (#21882)
Browse files Browse the repository at this point in the history
Also, run it via exact version instead of relying on global binary.
  • Loading branch information
silverwind authored Nov 21, 2022
1 parent 43aafc5 commit 9380bb6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
10 changes: 0 additions & 10 deletions .drone.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,6 @@ steps:
- make lint-frontend
depends_on: [deps-frontend]

- name: security-check
image: golang:1.19
pull: always
commands:
- make security-check
depends_on: [deps-backend]
volumes:
- name: deps
path: /go

- name: lint-backend
image: gitea/test_env:linux-amd64 # https://gitea.com/gitea/test-env
pull: always
Expand Down
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ checks: checks-frontend checks-backend
checks-frontend: lockfile-check svg-check

.PHONY: checks-backend
checks-backend: tidy-check swagger-check fmt-check misspell-check swagger-validate
checks-backend: tidy-check swagger-check fmt-check misspell-check swagger-validate security-check

.PHONY: lint
lint: lint-frontend lint-backend
Expand Down Expand Up @@ -745,7 +745,7 @@ generate-go: $(TAGS_PREREQ)

.PHONY: security-check
security-check:
govulncheck -v ./...
go run $(GOVULNCHECK_PACKAGE) -v ./...

$(EXECUTABLE): $(GO_SOURCES) $(TAGS_PREREQ)
CGO_CFLAGS="$(CGO_CFLAGS)" $(GO) build $(GOFLAGS) $(EXTRA_GOFLAGS) -tags '$(TAGS)' -ldflags '-s -w $(LDFLAGS)' -o $@
Expand Down

0 comments on commit 9380bb6

Please sign in to comment.