Fix unclosed session bug (#2214)

ethantkoenig · lunny · commit 5f37944dff7f · 2017-07-26T17:30:47.000+08:00
diff --git a/models/issue.go b/models/issue.go
@@ -1097,8 +1097,8 @@ func Issues(opts *IssuesOptions) ([]*Issue, error) {
 		sess = x.Limit(setting.UI.IssuePagingNum, start)
 	} else {
 		sess = x.NewSession()
-		defer sess.Close()
 	}
+	defer sess.Close()
 
 	if len(opts.IssueIDs) > 0 {
 		sess.In("issue.id", opts.IssueIDs)

Original file line number	Diff line number	Diff line change
`@@ -1097,8 +1097,8 @@ func Issues(opts IssuesOptions) ([]Issue, error) {`
`1097`	`1097`	`sess = x.Limit(setting.UI.IssuePagingNum, start)`
`1098`	`1098`	`} else {`
`1099`	`1099`	`sess = x.NewSession()`
`1100`		`- defer sess.Close()`
`1101`	`1100`	`}`
	`1101`	`+ defer sess.Close()`
`1102`	`1102`
`1103`	`1103`	`if len(opts.IssueIDs) > 0 {`
`1104`	`1104`	`sess.In("issue.id", opts.IssueIDs)`