Skip to content

Fix unclosed session bug #2214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2017
Merged

Fix unclosed session bug #2214

merged 1 commit into from
Jul 26, 2017

Conversation

@ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jul 26, 2017

Make sure defer sess.Close() always gets hit.

@lafriks
Copy link
Member

lafriks commented Jul 26, 2017

LGTM

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 26, 2017
@sapk
Copy link
Member

sapk commented Jul 26, 2017

LGTM

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 26, 2017
@lunny lunny added this to the 1.2.0 milestone Jul 26, 2017
@lunny lunny added the type/bug label Jul 26, 2017
@lunny
Copy link
Member

lunny commented Jul 26, 2017

This is not real a bug. When you call x.Where().Find, session.Close is not necessary since Find will check and close that.

@lunny lunny merged commit 5f37944 into go-gitea:master Jul 26, 2017
@ethantkoenig ethantkoenig deleted the fix/sess_close branch July 26, 2017 15:01
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ethantkoenig @lafriks @sapk @lunny @bkcsoft