Skip to content

Switch to go-flutter-desktop engine builds, update snapshot generation #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Switch to go-flutter-desktop engine builds, update snapshot generation #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,6 @@ func buildFlutterBundle(targetOS string) {
}
generateAotSnapshotCommand := []string{
darwinhacks.RewriteDarlingPath(useDarling, genSnapshot),
"--no-causal-async-stacks",
"--lazy-async-stacks",
"--deterministic",
"--snapshot_kind=app-aot-elf",
Expand Down
4 changes: 2 additions & 2 deletions internal/enginecache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,14 +309,14 @@ func ValidateOrUpdateEngine(targetOS, cachePath, requiredEngineVersion string, m
file += "windows"
}
file += fmt.Sprintf("_x64-host_%s.zip", mode.Name)
engineDownloadURL := fmt.Sprintf("https://github.com/flutter-rs/engine-builds/releases/download/f-%s/%s", requiredEngineVersion, file)
engineDownloadURL := fmt.Sprintf("https://github.com/go-flutter-desktop/engine-builds/releases/download/f-%s/%s", requiredEngineVersion, file)

err = downloadFile(engineZipPath, engineDownloadURL)
if err != nil {
log.Errorf("Failed to download engine: %v", err)
log.Errorf("Engine builds are a bit delayed after they are published in flutter.")
log.Errorf("You can either try again later or switch the flutter channel to beta, because these engines are more likely to be already built.")
log.Errorf("To dig into the already built engines look at https://github.com/flutter-rs/engine-builds/releases and https://github.com/flutter-rs/engine-builds/actions")
log.Errorf("To dig into the already built engines look at https://github.com/go-flutter-desktop/engine-builds/releases and https://github.com/go-flutter-desktop/engine-builds/actions")
os.Exit(1)
}
_, err = unzip(engineZipPath, engineExtractPath)
Expand Down