Fix segfault in debug mode #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
fix/debug-mode-segfault
branch
from
d525cad to
5699463
Compare
GeertJohan
reviewed
Oct 25, 2020
| @@ -639,7 +639,11 @@ func buildEnv(targetOS string, engineCachePath string) []string { | |||
| switch targetOS { | |||
| case "darwin": | |||
| cgoLdflags += fmt.Sprintf(" -L%s -L%s", engineCachePath, outputDirPath) | |||
| cgoLdflags += fmt.Sprintf(" -lflutter_engine -Wl,-rpath,.") | |||
| if buildOrRunMode == build.DebugMode { | |||
There was a problem hiding this comment.
Maybe needs a comment about why this is necessary and how this works?
provokateurin
force-pushed
the
fix/debug-mode-segfault
branch
from
5699463 to
1f4fcdb
Compare
provokateurin
force-pushed
the
fix/debug-mode-segfault
branch
from
1f4fcdb to
088ef59
Compare
|
This should work now. Some ld flags were still wrong. I tested it on a MacOS VM in debug and release |
|
@JanezStupar @jonas1-4 can you test this PR to confirm it fixes everything? |
It works fine on my end! |
|
Great |
|
Everything works fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the official engines in debug mode (like previously).