Skip to content

NSHighResolutionCapable true, local building of darwin packages #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Conversation

sidevesh
Copy link
Contributor

Set NSHighResolutionCapable to true to prevent blurry appeareance on Mac OS,
Add support for building darwin-bundle, darwin-dmg and darwin-pkg locally on darwin

…Mac OS, support building darwin-bundle, darwin-dmg and darwin-pkg locally on darwin
@provokateurin
Copy link
Member

I will test this in my MacOS VM soon

@provokateurin
Copy link
Member

provokateurin commented Aug 20, 2020

Building works fine, but did you try installing the pkg? When installing using the GUI it shows there is an error and when installing using the installer command it also shows there is an error (stops at 97.75%), but no log is generated even with -verbose. I think this PR isn't the breaking change, but I would appreciate it if you can try to also fix it as working in the VM is a pain

@sidevesh
Copy link
Contributor Author

@jld3103 made the suggested changes,
didn't try installing pkg since my app doesn't use darwin-pkg format,
don't think its related to this PR since in darwin-pkg case the tool used for packaging mkbom is the same for both linux and darwin.
Will give it a try though, that could be a separate PR.

@provokateurin
Copy link
Member

LGTM

@provokateurin provokateurin merged commit a8cb5e6 into go-flutter-desktop:master Aug 26, 2020
@provokateurin
Copy link
Member

@sidevesh Released in v0.43.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants