Feature/mac os shortcuts #65
Conversation
There was a problem hiding this comment.
ModShiftControl is still hard coded.
Since the modifierKey is not necessarily Control, the change must take into account the new modifierKey in some statements.
It might me the time to move away from passing int(mods) into each state functions.
I would rather have a Boolean saying which modifier is active or not.
i.e.state.MoveCursorLeft(true, false) for CursorLeft + shift + no-ctrl/meta
There was a problem hiding this comment.
https://transfer.sh/u2ct3/flutter.gif
Regression: ctrl-Left/Right isn't working anymore.
Regression: when the key Left is pressed it send the cursor to the start of the input.
|
Have the regressions been resolved? (I don't have a Mac currently) |
|
I solved them on MacOS but didn't had time to test them on linux, we had some issues but I should have fixed the. But still I didn't implemented what you suggested in #51 |
|
I think using runtime.GOOS is good as well. I'll test this PR tomorow evening on linux. |
|
I've just merged master into this branch to make it compile again with the moved repo. I did some testing. This still is this case on my linux machine:
The other regression has indeed been solved for linux. |
|
I'll try to look into it ASAP |
3 participants
This feature add support for Mac.
Before this the modifier key was Control even on MacOS.
With this fix, windows and linux will have Control as modifierKey whereas MacOS will have cmd which is more natural.
I decided to not add this to the configuration file because we wouldn't be compatible to each architecture or we would need to add modifier key for each platform.
I'm up for any suggestion to improve this.