Implement flutter/mousecursor #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchampio
reviewed
May 19, 2020
pchampio
reviewed
May 19, 2020
pchampio
requested changes
May 19, 2020
|
Newer version of glfw have support for a wider range of cursor type. Please add TODO comments |
provokateurin
force-pushed
the
feature/mousecursor
branch
from
9057227 to
a52db57
Compare
pchampio
reviewed
May 20, 2020
pchampio
reviewed
May 20, 2020
pchampio
requested changes
May 20, 2020
provokateurin
force-pushed
the
feature/mousecursor
branch
from
a52db57 to
73b07b7
Compare
pchampio
approved these changes
May 22, 2020
GeertJohan
reviewed
May 24, 2020
pchampio
reviewed
May 25, 2020
|
@jld3103 Can this feature be tested in any of the Flutter versions (including master)? It looks interesting to try out at least. |
|
I think it is still not in beta, but you can just try it on master |
|
@jld3103 Thanks! It actually works in the current beta branch. It was my bad, when I tried it, I was a bit behind in the go-flutter version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of flutter/flutter@7f8cb7f
Cursor list from https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/rendering/mouse_cursor.dart