Skip to content

Add AOT capability #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 23, 2020
Merged

Add AOT capability #331

merged 4 commits into from
Jan 23, 2020

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Dec 30, 2019 •
edited
Loading

No description provided.

dvc94ch
dvc94ch reviewed Dec 30, 2019
View reviewed changes
@provokateurin provokateurin force-pushed the feature/aot branch 5 times, most recently from dbd47ee to 9e103ad Compare December 31, 2019 12:55
@provokateurin
Copy link
Member Author

flutter/flutter#48018

@provokateurin provokateurin force-pushed the feature/aot branch 3 times, most recently from 8d34d7c to 8670000 Compare January 4, 2020 10:57
@provokateurin provokateurin mentioned this pull request Jan 20, 2020
Closed
3 tasks
@provokateurin provokateurin marked this pull request as ready for review January 20, 2020 19:03
@provokateurin provokateurin changed the title [WIP] Add AOT capability Add AOT capability Jan 20, 2020
pchampio
pchampio requested changes Jan 21, 2020
View reviewed changes
Copy link
Member

@pchampio pchampio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wav, this was a very small diff, and It can be even smaller.
I'll rather use the FlutterEngineRunsAOTCompiledDartCode function instead of adding a new build-constant

@provokateurin
Copy link
Member Author

Did some cleanup @pchampio

@provokateurin provokateurin mentioned this pull request Jan 22, 2020
Closed
3 tasks
@pchampio
refactor: use FlutterEngineRunsAOTCompiledDartCode
8287668 
Use FlutterEngineRunsAOTCompiledDartCode instead of another
build-constant
@pchampio
chore: remove unused C helper function
ee0749f
@pchampio pchampio self-requested a review January 22, 2020 21:04
pchampio
pchampio approved these changes Jan 22, 2020
View reviewed changes
Copy link
Member

@pchampio pchampio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made some very slight changes.
LGTM, but please test/review my stuff ;)

provokateurin
provokateurin commented Jan 23, 2020
View reviewed changes
@provokateurin
Copy link
Member Author

Apart from the wrong TODO everything LGTM and works

@pchampio pchampio merged commit 6244ff9 into go-flutter-desktop:master Jan 23, 2020
@pchampio
Copy link
Member

With your version of hover (go-flutter-desktop/hover#77).
This can be tested with: hover build linux --release.

@provokateurin
Copy link
Member Author

I'll update the short tutorial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pchampio pchampio pchampio approved these changes

+1 more reviewer

@dvc94ch dvc94ch dvc94ch left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin @pchampio @dvc94ch