Feature/callback messages #220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang impl of flutter/engine@6aad139
I chose to break the plugin api:
Why?
Peoples are used to not return result in their flutter
setMethodCallHandler
/setMessageHandler
.example:
With a InvokeMethod that expect a reply, the embedder will wait forever, (not blocking the UI but the behavior isn't normal).
The uses of
InvokeMethodWithReply
andSendWithReply
is enough to let the user know he has to return a value in the flutter handler.*WithReply
is also used in the flutter/engine desktop shell, users will not get lost.