Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/dap: provide process events after launch #3902

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

shaunduncan
Copy link
Contributor

This change adds support to emit the process DAP event after handling launch requests.

Note: I found myself in a situation where I needed this exact event get process information from delve. I discovered this event was not implemented, so I have added it in the place that seems to be the most logical place (just based on my limited exposure to the codebase). Please let me know if this change is unwarranted or if useful, if it needs any additional work.

Thanks!

This change adds support to emit the process DAP event after handling launch
requests
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 38af36e into go-delve:master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants