Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service/test: disable TestGuessSubstitutePath on TeamCity/linux/tip #3890

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

aarzilli
Copy link
Member

It does not work because of how TeamCity creates the build directory.

@@ -3156,6 +3156,11 @@ func TestBreakpointVariablesWithoutG(t *testing.T) {

func TestGuessSubstitutePath(t *testing.T) {
t.Setenv("NOCERT", "1")
ver, _ := goversion.Parse(runtime.Version())
if ver.IsDevelBuild() && os.Getenv("CI") != "" && runtime.GOOS == "linux" {
t.Skip("does not work in TeamCity + tip + linux")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a quick comment for reference on the TeamCity issue that's causing this failure.

It does not work because of how TeamCity creates the build directory.
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 37422e6 into go-delve:master Jan 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants