Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to replay for rr onprocess pid #3281

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

jcpowermac
Copy link
Contributor

Add -p or rr-onprocess-pid to replay
command to pass -p or --onprocess pid
to rr.

@jcpowermac
Copy link
Contributor Author

I was unsure about submitting this PR. If there is an alternative way to do this please let me know.

When using rr with openshift installer I couldn't find a way to debug the terraform providers which is forked from terraform and terraform is forked from the installer.

Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation needs to be regenerated by executing: go run _scripts/gen-usage-docs.go

cmd/dlv/cmds/commands.go Outdated Show resolved Hide resolved
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add `-p` or `rr-onprocess-pid` to replay
command to pass `-p` or `--onprocess` pid
to `rr`.
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit c0b0148 into go-delve:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants