Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TeamCity: fix windows/amd64 builds #3223

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Conversation

aarzilli
Copy link
Member

Windows/amd64 builds are not runnning because the current settings.kts
has an implicity requirement to property teamcity.build.systemDir which
does not exist on windows/amd64 agents.

@aarzilli
Copy link
Member Author

Unfortunately we have to merge this to see if it works.
cc @qmuntal

@qmuntal
Copy link
Contributor

qmuntal commented Dec 15, 2022

Hmm, I'm wondering if the windows/amd64 agent has this property. I couldn't test it when working on the original PR because the settings.kts needs to reach master before being applied. What I did was to to add a sane fallback inside test_windows.ps1 in case teamcity.build.systemDir wasn't there, which does work well.

I think it's better to just rely on the fallback systemDir and remove the teamcity.build.systemDir for now.

Windows/amd64 builds are not runnning because the current settings.kts
has an implicity requirement to property teamcity.build.systemDir which
does not exist on windows/amd64 agents.
@aarzilli
Copy link
Member Author

I think it's better to just rely on the fallback systemDir and remove the teamcity.build.systemDir for now.

Like this?

@qmuntal
Copy link
Contributor

qmuntal commented Dec 15, 2022

I think it's better to just rely on the fallback systemDir and remove the teamcity.build.systemDir for now.

Like this?

Yep.

Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit 32df407 into go-delve:master Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants