Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for go1.18beta1 #2831

Merged
merged 5 commits into from
Dec 22, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
TeamCity: bump test matrix
Add 1.18 to test matrix. Remove 1.15 from test matrix and from support range.
  • Loading branch information
aarzilli committed Dec 19, 2021
commit 4e8d9525c1ff216575217e4f9442f58ef7b64208
12 changes: 6 additions & 6 deletions .teamcity/settings.kts
Original file line number Diff line number Diff line change
Expand Up @@ -35,23 +35,23 @@ To debug in IntelliJ Idea, open the 'Maven Projects' tool window (View
version = "2020.2"

val targets = arrayOf(
"linux/amd64/1.15",
"linux/amd64/1.16",
"linux/amd64/1.17",
"linux/amd64/1.18",
"linux/amd64/tip",

"linux/386/1.17",
"linux/386/1.18",

"linux/arm64/1.17",
"linux/arm64/1.18",
"linux/arm64/tip",

"windows/amd64/1.17",
"windows/amd64/1.18",
"windows/amd64/tip",

"mac/amd64/1.17",
"mac/amd64/1.18",
"mac/amd64/tip",

"mac/arm64/1.17",
"mac/arm64/1.18",
"mac/arm64/tip"
)

Expand Down
4 changes: 0 additions & 4 deletions _scripts/test_linux.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,6 @@ function getgo {
}

if [ "$version" = "gotip" ]; then
# TODO: remove this
if [ "$arch" != "amd64" ]; then
exit 0
fi
echo Building Go from tip
getgo $(curl https://go.dev/VERSION?m=text)
export GOROOT_BOOTSTRAP=$GOROOT
Expand Down
4 changes: 0 additions & 4 deletions _scripts/test_mac.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@ ARCH=$2
TMPDIR=$3

if [ "$GOVERSION" = "gotip" ]; then
# TODO: remove this
if [ "$arch" != "amd64" ]; then
exit 0
fi
bootstrapver=$(curl https://go.dev/VERSION?m=text)
cd $TMPDIR
curl -sSL "https://storage.googleapis.com/golang/$bootstrapver.darwin-$ARCH.tar.gz" | tar -xz
Expand Down
2 changes: 1 addition & 1 deletion _scripts/test_windows.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function GetGo($version) {
}

if ($version -eq "gotip") {
Exit 0
#Exit 0
$latest = Invoke-WebRequest -Uri https://golang.org/VERSION?m=text -UseBasicParsing | Select-Object -ExpandProperty Content
GetGo $latest
$env:GOROOT_BOOTSTRAP = $env:GOROOT
Expand Down
2 changes: 1 addition & 1 deletion pkg/goversion/compat.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (

var (
MinSupportedVersionOfGoMajor = 1
MinSupportedVersionOfGoMinor = 15
MinSupportedVersionOfGoMinor = 16
MaxSupportedVersionOfGoMajor = 1
MaxSupportedVersionOfGoMinor = 17
goTooOldErr = fmt.Sprintf("Go version %%s is too old for this version of Delve (minimum supported version %d.%d, suppress this error with --check-go-version=false)", MinSupportedVersionOfGoMajor, MinSupportedVersionOfGoMinor)
Expand Down