Skip to content

Commit

Permalink
Remove references to freebsd
Browse files Browse the repository at this point in the history
  • Loading branch information
alexsaezm committed Apr 19, 2023
1 parent 95100a3 commit f93efa0
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions pkg/proc/native/proc.go
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,6 @@ func (dbp *nativeProcess) initialize(path string, debugInfoDirs []string) (*proc
// We disable asyncpreempt for the following reasons:
// - on Windows asyncpreempt is incompatible with debuggers, see:
// https://github.com/golang/go/issues/36494
// - freebsd's backend is generally broken and asyncpreempt makes it even more so, see:
// https://github.com/go-delve/delve/issues/1754
// - on linux/arm64 asyncpreempt can sometimes restart a sequence of
// instructions, if the sequence happens to contain a breakpoint it will
// look like the breakpoint was hit twice when it was "logically" only
Expand All @@ -257,7 +255,7 @@ func (dbp *nativeProcess) initialize(path string, debugInfoDirs []string) (*proc
// with gdb once AsyncPreempt was enabled. While implementing the port,
// few tests failed while it was enabled, but cannot be warrantied that
// disabling it fixed the issues.
DisableAsyncPreempt: runtime.GOOS == "windows" || runtime.GOOS == "freebsd" || (runtime.GOOS == "linux" && runtime.GOARCH == "arm64") || (runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le"),
DisableAsyncPreempt: runtime.GOOS == "windows" || (runtime.GOOS == "linux" && runtime.GOARCH == "arm64") || (runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le"),

StopReason: stopReason,
CanDump: runtime.GOOS == "linux" || (runtime.GOOS == "windows" && runtime.GOARCH == "amd64"),
Expand Down

0 comments on commit f93efa0

Please sign in to comment.