fix(router): optional StrictRouting for static 405 precedence - #1136
Open
Solaris-star wants to merge 1 commit into
Open
fix(router): optional StrictRouting for static 405 precedence#1136Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
When StrictRouting is enabled, an exact static path that exists for other
methods returns 405 instead of falling through to a param/regexp sibling
(e.g. PUT /users/me no longer matches PUT /users/{id}).
Default remains false to preserve historical chi behavior covered by
TestTreeMoar.
Fixes go-chi#1035
Solaris-star
force-pushed
the
fix/1035-static-method-not-allowed-precedence
branch
from
July 21, 2026 12:36
09c4bf6 to
b7f10a9
Compare
Solaris-star
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
/users/meis registered for GET and/users/{id}for PUT, aPUT /users/mecurrently falls through to the param route (id=me) instead of returning 405 for the exact static path (#1035).Historical chi behavior (see
TestTreeMoar) intentionally allows method fallthrough to param siblings in some cases, so this is opt-in.Fix
Mux.StrictRouting(bool)Test plan
go test ./...TestStaticRouteMethodNotAllowedOverParam(withStrictRouting(true))TestTreeMoarstill passes with default (false)Fixes #1035