Join the Stream and Verbose flags into the verbosity value #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 27, 2016 13:24
If the runner needs the Stream value from the config, it should not get it from the reporter. It is better to keep a copy of the value in the runner itself to make the communication between runner and reporter only one-direction.
Contributor
|
This is a public API on a very stable package. We can't break people's code unless it's a critical issue. |
Author
|
That's why I split it in two commits, so we could discuss about it. I was thinking that it might be good to start working on v2. But anyway... I proposed only the first commit in #73. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word Stream is confusing. It has many meanings, and it's not clear that it means more verbose than verbose. In addition to that, using a numerical value allows future runners and reporters to have a mode that's even more verbose than Stream.
The first commit doesn't change the RunConf type, that's public. It is changed in the second commit.
Requires #71.