stacktrace loops infinitely on GCCGO, this fixes the issue #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
Author
|
Please review and merge this PR, we need this to avoid tests hanging on IBM Power and Z. |
|
@niemeyer this is a blocking issue for porting Docker to non-x86 platforms - any chance we could get it reviewed? thanks |
|
@brahmaroutu @duglin if this is still an issue, we decided to fork go-check in the meantime, so you can reopen this PR against our fork; see moby/moby#21017 |
Author
|
@thaJeztah This feature is not used in the tests now. When gccgo builds break, we can then react to fix this. Thanks for your consideration and sorry for delayed response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Docker tests with GCCGO 5.1, for supporting non-X86 architecture, stack trace is looping infinitely. This PR fixes that issue
Signed-off-by: Srini Brahmaroutu srbrahma@us.ibm.com