feat: Initial implementation of base85 + testing + docs #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation provides a Base85 implementation with an API similar to encoding/base64 so that custom alphabets and paddings can be provided. Using this we provide RFC1924 as a standard alphabet. This is being provided because the standard `ascii85` implementation does not allow custom character sets that would enable use of RFC1924 or other denser encodings (compared to Base64 which is the most dense built-in encoding) provided in standard go.
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This improves performance, but overall still lacks compared to ascii85, in part because of the need for the alphabet character map lookup vs being able to use the continious range in ascii85.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation provides a Base85 implementation with an API similar to encoding/base64 so that custom alphabets and paddings can be provided. Using this we provide RFC1924 as a standard alphabet.
This is being provided because the standard
ascii85implementation does not allow custom character sets that would enable use of RFC1924 or other denser encodings (compared to Base64 which is the most dense built-in encoding) provided in standard go.Also included in this PR is the testing, CI, Dependabot config, and docs for the repo + base85 functionality.