Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add precedence to de-facto headers X-Forwarded-Host, X-Forwarded-Port #247

Closed
jeevatkm opened this issue Jan 31, 2019 · 1 comment
Closed

Add precedence to de-facto headers X-Forwarded-Host, X-Forwarded-Port #247

jeevatkm opened this issue Jan 31, 2019 · 1 comment
Assignees
@jeevatkm
Labels
enhancement lib-ahttp HTTP - extension to standard one
Milestone
v0.13.0 Milestone

Comments

@jeevatkm
Copy link
Member

The goal of this issue to give precedence to de-facto standard header X-Forwarded-Host & X-Forwarded-Port for retrieving Host value like we did for processing Scheme and ClientIP.

References:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/X-Forwarded-Host
https://docs.aws.amazon.com/elasticloadbalancing/latest/classic/x-forwarded-headers.html
@jeevatkm jeevatkm added enhancement lib-ahttp HTTP - extension to standard one labels Jan 31, 2019
@jeevatkm jeevatkm added this to the v0.13.0 Milestone milestone Jan 31, 2019
@jeevatkm jeevatkm self-assigned this Feb 6, 2019
jeevatkm added a commit that referenced this issue Feb 6, 2019
@jeevatkm
#247 added defacto header precedence for host header and improvements
205d56e
@jeevatkm
Copy link
Member Author

jeevatkm commented Feb 6, 2019

Its done 😄

@jeevatkm jeevatkm closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeevatkm jeevatkm

Labels
enhancement lib-ahttp HTTP - extension to standard one
Projects
None yet
Milestone
v0.13.0 Milestone
Development

No branches or pull requests
1 participant
@jeevatkm