Create files to support NSMovie and NSMovieView #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredkiefer
reviewed
Jan 13, 2023
fredkiefer
reviewed
Jan 13, 2023
…nges, and config.make/config.h changes
|
Completely revamped and simplified. |
…GSMovieView move decoding entirely to threads
|
I think this is the best I can do on this. @fredkiefer could you take a look and see what else you might be able to see. This is certainly better than we have at the moment (nothing) and I think it would be useful for others to take a look and try to improve this. |
The sound is now working and I have added a set of (default) controls. |
fredkiefer
requested changes
Aug 2, 2025
|
@fredkiefer Take a look at the updates. Thanks for reviewing the code. |
|
I had to revert some of the previous changes. Back to fac27f8. You'll need to do a fresh checkout. |
|
@fredkiefer I have addressed the issues you mentioned. :) |
…case the video slows down
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation for NSMovie and NSMovieView. The tests for this are here:
https://github.com/gcasa/NSMovie_test
https://github.com/gcasa/apps-videoplayer