CFBag: add a test suite for creation, lookup and mutation#70
Open
DTW-Thalion wants to merge 1 commit into
Open
CFBag: add a test suite for creation, lookup and mutation#70DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
CFBag.c had little direct coverage. Add tests exercising the public API: CFBagCreate and its multiset counting (CFBagGetCount, CFBagGetCountOfValue), lookup (CFBagContainsValue, CFBagGetValue, CFBagGetValueIfPresent, CFBagGetValues), CFBagCreateCopy, the type ID, and CFEqual / CFHash. The mutable path covers CFBagCreateMutable, CFBagAddValue, CFBagSetValue, CFBagReplaceValue, CFBagRemoveValue, CFBagRemoveAllValues and CFBagCreateMutableCopy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFBag.chad little direct test coverage. This adds a self-contained CFBag test suite (Tests/CFBag) built on the existingCFTesting.hframework.Immutable (
create.m):CFBagCreateand multiset counting —CFBagGetCount,CFBagGetCountOfValue(including a repeated value and an absent value).CFBagContainsValue,CFBagGetValue,CFBagGetValueIfPresent,CFBagGetValues.CFBagCreateCopy,CFBagGetTypeID/CFGetTypeID, andCFEqual/CFHash.Mutable (
mutable.m):CFBagCreateMutable,CFBagAddValue,CFBagSetValue,CFBagReplaceValue(present and absent),CFBagRemoveValue,CFBagRemoveAllValues,CFBagCreateMutableCopy.This raises
CFBag.cline coverage from 22.6% to 93.5% (measured with llvm-cov). All new tests pass and no existing tests are affected. The two remaining uncovered functions are the emptyCFBagApplyFunctionstub and the internal formatting-description helper.