Skip to content

CFNumber: add missing break statements in CFNumberGetType #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DTW-Thalion wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CFNumber: add missing break statements in CFNumberGetType #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d39a434
CFNumber: add missing break statements in CFNumberGetType
DTW-Thalion Jun 28, 2026
fbd8ec7
CFNumber: drop the explanatory comment in the gettype test per review
DTW-Thalion Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Source/CFNumber.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,22 +416,29 @@ CFNumberGetType (CFNumberRef num)
case _C_CHR:
case _C_UCHR:
cfType = kCFNumberCharType;
break;
case _C_SHT:
case _C_USHT:
cfType = kCFNumberShortType;
break;
case _C_INT:
case _C_UINT:
cfType = kCFNumberIntType;
break;
case _C_LNG:
case _C_ULNG:
cfType = kCFNumberLongType;
break;
case _C_LNG_LNG:
case _C_ULNG_LNG:
cfType = kCFNumberLongLongType;
break;
case _C_FLT:
cfType = kCFNumberFloatType;
break;
case _C_DBL:
cfType = kCFNumberDoubleType;
break;
}
return cfType;
}
Expand Down
13 changes: 13 additions & 0 deletions Tests/CFNumber/gettype.m
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
#import <Foundation/NSValue.h>
#include "CoreFoundation/CFNumber.h"
#include "../CFTesting.h"

int main (void)
{
NSNumber *i = [NSNumber numberWithInt: 5];

PASS_CF(CFNumberGetType((CFNumberRef)i) == kCFNumberIntType,
"An integer NSNumber reports kCFNumberIntType, not kCFNumberDoubleType.");

return 0;
}