-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling VOLK_CPU_FEATURES causes tests to fail on 2.5.0 #484
Comments
Thanks for your report. I assume, we need to wait for this patch to be merged into cpu_features and then update our dependencies. This might also fix #478 . |
Thanks, are tests however expected to fail without cpu_features? |
VOLK did always rely on CPU feature detection. Thus, I'd doubt we ever tested it without cpu_features. Besides, I can't tell why your tests failed specifically. |
Hi, === configure log ===
=== test log (verbose) ===
Hope it helps |
Hi @diizzyy Which CPU do you have in your computer? An Intel Ivy Bridge Core processor? |
Ahh sorry, yes it's an Ivy Bridge one |
Now, we can analyze this issue a bit further. Tests that fail show this line: Without |
Perhaps a better approach would be to assume that lets instructions up to SSE4 and/or AVX are available if cpu_features is disabled or just remove that option? |
The main issue for FreeBSD is how we do our sysctls for such detection, see google/cpu_features#159. |
@diizzyy Unfortunately, there isn't a "quick fix". I pushed to adopt cpu_features because it is difficult and cumbersome to implement CPU feature detection (and we had long standing bugs that we could fix on the way). @vishwin Thanks for this hint. I hope this PR will be merged soon. Afterwards we can update our cpu_feature dependency and we might even find a way to run CI for FreeBSD. At least I'd be happy to have it. |
I assume we can fix this issue by moving to a newer We should have a look at their CI system to run VOLK tests as well. |
We have 3 issues that should be fixed with this commit. Fix gnuradio#428 Should be fixed because cpu_features detects `arm64` now. Thus, it builds on MacOS and reports M1 capabilities. Fix gnuradio#478 Fix gnuradio#484 cpu_features received quite a bit of contributions for FreeBSD. All the issues we had should be fixed now. However, this might require further evaluation. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
We have 3 issues that should be fixed with this commit. Fix gnuradio#428 Should be fixed because cpu_features detects `arm64` now. Thus, it builds on MacOS and reports M1 capabilities. Fix gnuradio#478 Fix gnuradio#484 cpu_features received quite a bit of contributions for FreeBSD. All the issues we had should be fixed now. However, this might require further evaluation. Signed-off-by: Johannes Demel <demel@uni-bremen.de>
Applying google/cpu_features#159 (patch needs more work) makes tests complete with VOLK_CPU_FEATURES enabled.
Tested on FreeBSD 13 (amd64)
The text was updated successfully, but these errors were encountered: