fix: failing script when adding as dependency #85

jfschwarz · 2022-11-17T15:55:50Z

The postinstall hook also runs when installing the package as a dependency, which will fail since we trigger solidity compilation etc.

prepare seems to be more suitable:

prepare (since npm@4.0.0)

Runs BEFORE the package is packed, i.e. during npm publish and npm pack

Runs on local npm install without any arguments

Runs AFTER prepublish, but BEFORE prepublishOnly

– https://docs.npmjs.com/cli/v8/using-npm/scripts#life-cycle-scripts

postinstall hook also runs when installing the package as a dependency, which will fail. `prepare` seems to be more suitable (see: https://docs.npmjs.com/cli/v9/using-npm/scripts#life-cycle-scripts)

samepant

lgtm

jfschwarz added 2 commits November 17, 2022 16:55

fix failing script when adding as dependency

07b3429

postinstall hook also runs when installing the package as a dependency, which will fail. `prepare` seems to be more suitable (see: https://docs.npmjs.com/cli/v9/using-npm/scripts#life-cycle-scripts)

bump version

a3da204

jfschwarz requested a review from samepant November 17, 2022 15:59

samepant approved these changes Nov 17, 2022

View reviewed changes

samepant merged commit 9346614 into master Nov 17, 2022

samepant deleted the fix-prepare-hook branch November 17, 2022 16:10

github-actions bot locked and limited conversation to collaborators Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: failing script when adding as dependency #85

fix: failing script when adding as dependency #85

jfschwarz commented Nov 17, 2022 •

edited

Loading

samepant left a comment

fix: failing script when adding as dependency #85

fix: failing script when adding as dependency #85

Conversation

jfschwarz commented Nov 17, 2022 • edited Loading

samepant left a comment

Choose a reason for hiding this comment

jfschwarz commented Nov 17, 2022 •

edited

Loading