Set eip4844 blob limits to 1/2 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4rgon4ut
approved these changes
Oct 11, 2023
|
@dapplion Looks good!
Is there supposed to be a link? |
yperbasis
suggested changes
Oct 12, 2023
There was a problem hiding this comment.
I believe that in that case DATA_GASPRICE_UPDATE_FRACTION should be set to 2225652. Refer to ethereum/EIPs#7154
Actually, sorry, 2225652 was the value for 2/4. We need to calculate the correct value for 1/2. |
|
|
yperbasis
added a commit
to erigontech/erigon
that referenced
this pull request
Oct 13, 2023
yperbasis
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Justification
Impact of the block size on Gnosis network performance, and reasoning for 1/2 choice: https://hackmd.io/@5qNKk0aeQlygax4hX3rVXw/SkY3dBV-6
Big blocks experiment summary
Noticeable degradation on the bucket 250-500Kb. Tolerable degradation on 130-262Kb.
Comparision to Ethereum rate
Per time rate =
3 * 5/12 / 6 * 5/12=1.25 / 2.5Proposal
1/2 is a conservation choice that should not increase network latency beyond key thresholds. Increasing this values can be done latter in response to demand and only requires changes on the execution layer clients.
Closes #18