check if network key exists #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ran into this problem while using buidler to compile contracts. They don't include network in the artifact by default so this line throws. I've opened an issue on their repo to follow truffle's artifacts format by including the network key. Couldn't hurt to check for the key here anyway...
Contributor
|
Thanks @okwme, I'd be OK to include this if you could provide a description of how to reproduce the issue! |
Contributor
Author
|
this is code i haven't touched for over a year so not able to provide a description of how to reproduce the issue. |
Contributor
|
Cool beans. Consider is merged! |
bh2smith
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ran into this problem while using buidler to compile contracts. They don't include network in the artifact by default so this line throws. I've opened an issue on their repo to follow truffle's artifacts format by including the network key. Couldn't hurt to check for the key here anyway...
NomicFoundation/hardhat#386