-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add orderbook list UI components #484
Comments
Discussion started here: |
New design is here https://zpl.io/b6KvD5m I will implement it when there's no more feedback. |
Gabriel, how can I get access to the new design?
…On Wed, Apr 21, 2021 at 6:28 PM Gabriel Rodriguez Alsina < ***@***.***> wrote:
New design is here https://zpl.io/b6KvD5m
I will implement it when there's no more feedback.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#484 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABU6OIDYUHRJ7TTX6S463P3TJ3VLHANCNFSM42UUZKRA>
.
|
https://www.figma.com/file/hapgMbgd2Zo5NFZDNfbogQ/Gnosis-Auction-Feedback |
@maria-vslvn is going to implement this. Some notes to help her understand what's needed to be done:
Regarding the design, you should: 0- Add the "Orderbook" title, just like it's on "Place Order", "Your Orders", etc. 1- Add a "Granularity" dropdown. The Idle style for the button must be like the "Max" button on the place order form. Hover / active style must be like in the design. No need to make the granularity work (ie: modify the table data dinamically). 2- Add these toggles to show and hide the orderbook's chart and table. 3- There's no radio button component you can use for the dropdown's options list, but you can duplicate 4- Add the Orderbook table like in the design. Mocked data is fine. You might want to have a look into the module we used for the auctions' list ( The table should be responsive, so at least allow for horizontal scrolling on smaller devices. No need to style the scrollbar, that's just for the design. Add the tooltips to the table's header. We don't have the tooltip's contents, but we can ask the guys here. |
@maria-vslvn is working on this, maybe we should add her as a collaborator to the repository. |
Yes, I asked her already to open her local PR as a PR to this repo. Would be great to have her work incorporated |
@josojo i've completed the scope. Currently i have all the updates in the copy repo. Should i create a PR to the native repo? |
Yes, either you creaate a native PR in this repo, or you make a PR from your clone. |
# Conflicts: # src/components/auction/Claimer/index.tsx # src/components/auction/OrderPlacement/index.tsx
order book is very useful for more detailed inspection of bids
I propose to add an orderbook to the main bidding interface
initial draft
Order book examples
Binance:
dydx:
The text was updated successfully, but these errors were encountered: