This repository has been archived by the owner on Jan 15, 2021. It is now read-only.
[Hotfix] Fix empty row bug in balances #1646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fixes empty row bug
Velenir
approved these changes
Nov 30, 2020
src/services/factories/tokenList.ts
Outdated
Comment on lines
293
to
301
| const tokensWithDetails = tokensConfig.reduce<TokenDetails[]>((acc, token) => { | ||
| if (!token.name || !token.symbol) { | ||
| tokensWithNoDetails.push(token) | ||
| return acc | ||
| } | ||
|
|
||
| acc.push(token) | ||
| return acc | ||
| }, []) |
There was a problem hiding this comment.
Not sure there's much advantage to reduce over a for loop if you do side effects (tokensWithNoDetails.push(token)) anyways
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
filterAndFillTokenDetailsfn to fill tokens that do not have pre-filled data when pulled from localStorageWhy? fixes empty row bug in balances
Problem was:
