-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gnoland): add subcommands support #937
Conversation
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
12363f8
to
a38c053
Compare
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks OK. What other subcommand would you like to add which would justify having subcommands? (init, in my opinion, could just be a flag...). Mostly asking as I don't think it makes sense to add the need to specify the "server" subcommand, both because it breaks old documentation and because it seems redundant (seeing as the gnoland binary's main "thing" is the server)
Current status:
@albttx explained that it's common to have those subcommands so that managing a node becomes more flexible. Here is what we have when running a common cosmos-sdk chain (note that it mixes node management, client and other things):
It would be beneficial to consider adding additional commands such as gnoland doctor or utility functions for working with the store, such as extracting contracts or state. I will rename |
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
18a1b78
to
7cf06f7
Compare
go.mod
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagine dep changes also coming from visualizations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you mean?
Maybe we also need to modify this[1] -./build/gnoland
+./build/gnoland start |
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
Changed the Developer Portal docs accordingly |
Co-authored-by: Hariom Verma <hariom18599@gmail.com>
BREAKING CHANGE: CLI usage changed for node operators.
gnoland
tognoland server
add a(won't do now, we need to choose between keeping lazy init ingnoland init
commandserver
+ havinginit
VS having always to run the two commands becauseserver
can't init)Addresses #731
Checklists...
Contributors Checklist
BREAKING CHANGE: xxx
message was included in the descriptionMaintainers Checklist
CONTRIBUTING.md
BREAKING CHANGE:
in the body)