feat: addpkg command respects gno.mod file #922

harry-hov · 2023-06-21T14:38:54Z

BREAKING CHANGE: removed flag -pkgPath from addpkg command

Since PR #763 we are parsing pkg path from gno.mod file while auto loading pkgs from /examples dir.
Replicate the same behavior for gnokey maketx addpkg ...

Contributors' checklist...

Added new tests, or not needed, or not feasible
Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
Updated the official documentation or not needed
No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
Added references to related issues and PRs
Provided any useful hints for running manual tests
Added new benchmarks to generated graphs, if any. More info here.

tbruyelle · 2023-06-21T21:10:32Z

@harry-hov do you think the same behavior should be applied for gno test ? That could help for #896.

harry-hov · 2023-06-22T09:21:14Z

@harry-hov do you think the same behavior should be applied for gno test ? That could help for #896.

Yeah. I planned to do this in #682. But now I will open a separate PR for that. That will act as a preparatory PR for both #896 and #682. (maybe by tomorrow)

tbruyelle · 2023-06-22T11:55:42Z

Yeah. I planned to do this in #682. But now I will open a separate PR for that. That will act as a preparatory PR for both #896 and #682. (maybe by tomorrow)

Awesome thank you

misc/docker-integration/integration_test.go

gnovm/pkg/gnomod/parse.go

moul · 2023-06-22T12:53:14Z

tm2/pkg/crypto/keys/client/addpkg.go

-	if cfg.pkgPath == "" {
-		return errors.New("pkgpath not specified")
-	}


we can make the migration smoother by just adding a warning here with a comment to remove later.

sorry. i didn't get it. what kind of warning?

I think we should also maintain a CHANGELOG and LongHelp?

tm2/pkg/crypto/keys/client/common.go

moul · 2023-06-27T07:15:22Z

tm2/pkg/crypto/keys/client/addpkg.go

+	"path/filepath"

 	gno "github.com/gnolang/gno/gnovm/pkg/gnolang"
+	"github.com/gnolang/gno/gnovm/pkg/gnomod"


This one is forbidden.

Maybe we should wait for TM2 split PR started by @piux2, then you'll have the AddPkg not in tm2 anymore, but in gno.land.

@harry-hov, what about trying to help @piux2 finishing his PR first?

tm2 already imports gnovm[github.com/gnolang/gno/gnovm](see the line above).

maybe we can let this one slide and will be fixed with TM2 split?

the split is finalised so the problematic import can be fixed, please merge master :)

codecov · 2023-11-27T13:24:36Z

Codecov Report

❌ Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
gno.land/pkg/keyscli/addpkg.go	50.00%	2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

thehowl

Catching up on old items in the queue. Sorry for the delay.

The changes LGTM though I personally think it would be better to have pkgpath still be a flag, which defaults to the value in gno.mod if not set.

My rationale: gnokey is primarily a tool to interact with the gno.land blockchain, and while gno.mod is a very important tool in local development, it is not essential to publish a package. So, in the way I see it, gnokey should essentially be the bare tool to create a transaction, with sane defaults like this one, but without asserting that gno.mod is a requirement.

What do you think?

harry-hov · 2024-04-08T09:13:00Z

Catching up on old items in the queue. Sorry for the delay.

Sorry for the delay in reply as well.

The changes LGTM though I personally think it would be better to have pkgpath still be a flag, which defaults to the value in gno.mod if not set.

I agree 💯 (but...)

My rationale: gnokey is primarily a tool to interact with the gno.land blockchain, and while gno.mod is a very important tool in local development, it is not essential to publish a package. So, in the way I see it, gnokey should essentially be the bare tool to create a transaction, with sane defaults like this one, but without asserting that gno.mod is a requirement.

My vision is to make gno.mod more inclusive. Let's take an example of the versioning PR #1631, which will also make gno.mod mandatory. If we all agree on having gno.mod on-chain at some point, then I think this is the right direction to make gno.mod a habit. Otherwise, we can proceed with what you suggested. Thoughts?

zivkovicmilos · 2024-05-14T16:12:47Z

@harry-hov
What is the status of this PR?

harry-hov · 2024-05-15T07:18:09Z

@zivkovicmilos last I remember, it was ready for review.

Seems like now i need to fix merge conflicts. Will do this soon!

harry-hov requested review from a team, jaekwon and moul as code owners June 21, 2023 14:38

github-actions bot added 📦 🌐 tendermint v2 Issues or PRs tm2 related 📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related labels Jun 21, 2023

github-actions bot assigned harry-hov Jun 21, 2023

harry-hov marked this pull request as draft June 21, 2023 19:34

harry-hov force-pushed the hariom/addpkg-respect-gnomod branch from 43104e0 to 1dd9130 Compare June 21, 2023 20:41

harry-hov marked this pull request as ready for review June 21, 2023 20:52

tbruyelle mentioned this pull request Jun 22, 2023

fix(gnovm): PrevRealm in _test files #896

Merged

9 tasks

moul reviewed Jun 22, 2023

View reviewed changes

misc/docker-integration/integration_test.go Outdated Show resolved Hide resolved

moul reviewed Jun 22, 2023

View reviewed changes

gnovm/pkg/gnomod/parse.go Show resolved Hide resolved

moul reviewed Jun 22, 2023

View reviewed changes

gnovm/pkg/gnomod/parse.go Show resolved Hide resolved

moul reviewed Jun 22, 2023

View reviewed changes

moul requested changes Jun 22, 2023

View reviewed changes

tm2/pkg/crypto/keys/client/common.go Outdated Show resolved Hide resolved

github-actions bot removed the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Jun 23, 2023

moul reviewed Jun 27, 2023

View reviewed changes

harry-hov mentioned this pull request Jul 23, 2023

gnomod bug demo gnolang/old-getting-started-workshop#18

Closed

moul added this to the 🌟 main.gno.land (wanted) milestone Sep 8, 2023

moul mentioned this pull request Nov 21, 2023

Minutes: Core Staff Weekly Syncs [every Monday] gnolang/meetings#36

Open

harry-hov force-pushed the hariom/addpkg-respect-gnomod branch from 1b19dd8 to c3acd88 Compare November 27, 2023 13:18

github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Nov 27, 2023

harry-hov requested a review from a team November 27, 2023 13:37

harry-hov force-pushed the hariom/addpkg-respect-gnomod branch from 697ef52 to 23ccecf Compare February 8, 2024 16:03

harry-hov requested a review from piux2 as a code owner February 8, 2024 16:03

harry-hov marked this pull request as draft February 8, 2024 16:27

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Feb 8, 2024

harry-hov marked this pull request as ready for review February 8, 2024 17:36

harry-hov requested review from a team and gfanton as code owners February 8, 2024 17:36

harry-hov requested review from moul, thehowl and zivkovicmilos February 8, 2024 17:36

thehowl reviewed Mar 4, 2024

View reviewed changes

harry-hov force-pushed the hariom/addpkg-respect-gnomod branch from a4260fc to d14ea00 Compare May 15, 2024 08:54

harry-hov requested review from a team, deelawn and mvertes as code owners May 15, 2024 08:54

harry-hov added 3 commits May 15, 2024 14:57

Add package helloworld for docker test

20a55aa

Remove -pkgPath from addPkg in favour of gno.mod

69703d7

Update docs and txtar(s)

e71b88f

harry-hov force-pushed the hariom/addpkg-respect-gnomod branch from d14ea00 to e71b88f Compare May 15, 2024 09:27

Kouteki assigned Kouteki and unassigned harry-hov Jun 14, 2024

Kouteki marked this pull request as draft June 14, 2024 09:21

ajnavarro self-assigned this Jun 14, 2024

Kouteki modified the milestones: 🌟 main.gno.land (wanted), ⏭️Next after mainnet Oct 16, 2024

jaekwon force-pushed the master branch from d3e0886 to 705e0df Compare May 3, 2025 20:18

thehowl closed this Aug 13, 2025

github-project-automation bot moved this from To triage to Done in TM2/GnoVM Aug 13, 2025

github-project-automation bot moved this to Done in 💪 Bounties & Worx Aug 13, 2025

feat: addpkg command respects gno.mod file #922

feat: addpkg command respects gno.mod file #922

Uh oh!

Conversation

harry-hov commented Jun 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbruyelle commented Jun 21, 2023

Uh oh!

harry-hov commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbruyelle commented Jun 22, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

moul Jun 22, 2023

Choose a reason for hiding this comment

Uh oh!

harry-hov Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

moul Jun 27, 2023

Choose a reason for hiding this comment

Uh oh!

harry-hov Dec 4, 2023

Choose a reason for hiding this comment

Uh oh!

thehowl Jan 25, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

thehowl left a comment

Choose a reason for hiding this comment

Uh oh!

harry-hov commented Apr 8, 2024

Uh oh!

zivkovicmilos commented May 14, 2024

Uh oh!

harry-hov commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

harry-hov commented Jun 21, 2023 •

edited

Loading

harry-hov commented Jun 22, 2023 •

edited

Loading

codecov bot commented Nov 27, 2023 •

edited

Loading