Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coverage): expand coverage with -coverpkg #3089

Closed
wants to merge 2 commits into from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Nov 8, 2024

Addresses #3003.

Following #3003 (comment). This PR expands coverage using -coverpkg. It's a generic and alternative approach compared to #3088.

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@gfanton gfanton self-assigned this Nov 8, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.67%. Comparing base (9129e4e) to head (d5470fa).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3089      +/-   ##
==========================================
+ Coverage   63.34%   66.67%   +3.33%     
==========================================
  Files         548      548              
  Lines       78652    78652              
==========================================
+ Hits        49822    52444    +2622     
+ Misses      25470    22805    -2665     
- Partials     3360     3403      +43     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.62% <ø> (+6.48%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 68.69% <ø> (+6.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Copy link
Member

@thehowl thehowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather we conservatively did this for the gno.land/ dir for now.

@gfanton
Copy link
Member Author

gfanton commented Nov 12, 2024

@thehowl yes, I agree and It takes double (probably more) the time of gnovm to finish tests, so it's not even worth considering, I guess...

closing in favor of #3088

@gfanton gfanton closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants