Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rework gno.land txtar package #3086

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Nov 7, 2024

  • improve overall setup for testscript for gnoland
  • add coverage support to gnoland coverage from gnoland should already be supported as it doesn't use any binary execution.
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests

@gfanton gfanton self-assigned this Nov 7, 2024
@github-actions github-actions bot added 📦 🤖 gnovm Issues or PRs gnovm related 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Nov 7, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 70.87719% with 166 lines in your changes missing coverage. Please review.

Project coverage is 66.67%. Comparing base (9129e4e) to head (9adfc59).

Files with missing lines Patch % Lines
gno.land/pkg/integration/testscript_gnoland.go 69.14% 128 Missing and 38 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   63.34%   66.67%   +3.33%     
==========================================
  Files         548      550       +2     
  Lines       78652    78699      +47     
==========================================
+ Hits        49822    52474    +2652     
+ Misses      25470    22815    -2655     
- Partials     3360     3410      +50     
Flag Coverage Δ
contribs/gnodev 61.16% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (ø)
gno.land 73.57% <69.70%> (+6.44%) ⬆️
misc/genstd 79.72% <ø> (ø)
tm2 68.67% <ø> (+6.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton changed the title WIP: add coverage support to gno.land feat: add txtar coverage support to gno.land Nov 7, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
@gfanton gfanton marked this pull request as ready for review November 7, 2024 19:34
@gfanton gfanton changed the title feat: add txtar coverage support to gno.land chore: rework gno.land txtar package Nov 7, 2024
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: No status
Status: In Review
Development

Successfully merging this pull request may close these issues.

1 participant