fix(tm2): rename methods to avoid conflicts with (un)marshaler interfaces #3000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aces amino codec.MarshallJSON has the same method name than Go standard library `json.Marshaler` interface but with a different signature. This is rejected by `go vet`. The same applies for codec.UnmarshallJSON vs `json.Unmarshaler`. To fix that, we rename codec.MarshalJSON to codec.JSONMarshal and codec.UnmarshalJSON to codec.JSONUnmarshal. Now `go vet ./...' pass on the full mono-repo. Fixes gnolang#2954.
mvertes
requested review from
jaekwon,
moul,
piux2 and
zivkovicmilos
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3000 +/- ##
==========================================
- Coverage 63.33% 62.97% -0.36%
==========================================
Files 548 546 -2
Lines 78601 80221 +1620
==========================================
+ Hits 49784 50523 +739
- Misses 25461 26281 +820
- Partials 3356 3417 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
thehowl
reviewed
Oct 22, 2024
thehowl
approved these changes
Oct 23, 2024
|
this looks good to me, but probably requires a check through @jaekwon . |
|
very personal experience, but for the human brain, |
ltzmaxwell
approved these changes
Oct 23, 2024
Let's merge this PR; we'll roll back if Jae has any objections. |
mvertes
added a commit
to mvertes/gno
that referenced
this pull request
Nov 5, 2024
After merge of gnolang#3000, a few missing field names in struct literal were reported. Fix it. No functional change.
2 tasks
mvertes
added a commit
that referenced
this pull request
Nov 5, 2024
After merge of #3000, a few missing field names in struct literal were reported. Fix it. No functional change. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [*] Added new tests, or not needed, or not feasible - [*] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [*] Updated the official documentation or not needed - [*] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amino
codec.MarshallJSONhas the same method name as Go standard libraryjson.Marshalerinterface but with a different signature. This is rejected bygo vet. The same applies forcodec.UnmarshallJSONvsjson.Unmarshaler. To fix that, we renamecodec.MarshalJSONtocodec.JSONMarshalandcodec.UnmarshalJSONtocodec.JSONUnmarshal.Now `go vet ./...' pass on the full mono-repo.
Fixes #2954.
BREAKING CHANGE: rename tm2 amino exported methods.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description