Skip to content

Experimenting will exposing underlying component ref for access to component methods #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 31, 2015

Conversation

gnoff
Copy link
Owner

@gnoff gnoff commented Jul 31, 2015

With the connect decorator the component you get back is a wrapper around the underlying component. If this underlying component has methods that are intended to be called by parents directly this gets int he way.

this PR is to expose the underlying ref via

decoratedComponentInstance.getUnderlyingRef()

gnoff added 2 commits July 31, 2015 00:19
… component. provide wrapper method to get underlying ref to provide access to unerlying refs methods
@gnoff
Copy link
Owner Author

gnoff commented Jul 31, 2015

based on reduxjs#16

@gaearon
Copy link

gaearon commented Jul 31, 2015

OK, I don't mind it.

gnoff added a commit that referenced this pull request Jul 31, 2015
exposing underlying component ref for access to component methods via DecoratedComponent#getUnderlyingRef
@gnoff gnoff merged commit 80ebc01 into master Jul 31, 2015
@gnoff gnoff deleted the underlyingRef branch August 6, 2015 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants