Skip to content
This repository was archived by the owner on Nov 30, 2022. It is now read-only.

Feature/php 8 support #664

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Feature/php 8 support #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
62ac488
Test PHP 8 support for Actions
gnikyt Jan 21, 2021
d03fdc8
Drop older Laravel versions
gnikyt Jan 21, 2021
73925a9
Exclude Laravel 7 from PHP 8 since Laravel 7 required ^7.2
gnikyt Jan 21, 2021
ec46fea
Use Laravel 8.22 as it supports PHP 8 and has no security reports
gnikyt Jan 21, 2021
0cf6b8f
Fix version 8.0 to 8.22 for Actions
gnikyt Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 7 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,15 @@ jobs:
- '7.2'
- '7.3'
- '7.4'
- '8.0'
laravel:
- '5.8'
- '6.0'
- '7.0'
- '8.0'
- '8.22'
exclude:
- php: '7.4'
laravel: '5.8'
- php: '7.2'
laravel: '8.0'
laravel: '8.22'
- php: '8.0'
laravel: '7.0'

name: PHP ${{ matrix.php }} / Laravel ${{ matrix.laravel }}

Expand All @@ -41,7 +40,7 @@ jobs:
run: composer validate --strict

- name: Install Laravel legacy factories support
if: matrix.laravel == '8.0'
if: matrix.laravel == '8.22'
run: composer require "laravel/legacy-factories:^1.0" --no-interaction --no-update

- name: Install Laravel and Orchestra Testbench
Expand All @@ -62,7 +61,7 @@ jobs:
run: vendor/bin/phpunit

- name: Upload coverage results
if: matrix.php == '7.4' && matrix.laravel == '8.0'
if: matrix.php == '8.22' && matrix.laravel == '8.22'
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

----

A full-featured Laravel package for aiding in Shopify App development, similar to `shopify_app` for Rails. Works for Laravel 5.6+
A full-featured Laravel package for aiding in Shopify App development, similar to `shopify_app` for Rails. Works for Laravel 7 and up.

![Screenshot](https://github.com/osiset/laravel-shopify/raw/master/screenshot.png)
![Screenshot: Billable](https://github.com/osiset/laravel-shopify/raw/master/screenshot-billable.png)
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"require": {
"php": ">=7.2",
"doctrine/dbal": "~2.5",
"funeralzone/valueobjects": "^0.4.5",
"funeralzone/valueobjects": "^0.5",
"jenssegers/agent": "^2.6",
"laravel/framework": "~5.8 || ^6.0 || ^7.0 || ^8.0",
"laravel/framework": "^7.0 || ^8.0",
"osiset/basic-shopify-api": "^9.0 || ^10.0"
},
"require-dev": {
Expand Down