application/json header in auth.shop middleware

[awebartisan]

I am trying to return json response from my controller but its being returned text/html; charset=UTF-8. On further digging, I found out that it only happens if I apply auth.shop middleware, as I remove it proper json response is returned. Kindly look into it.

[gnikyt]

Hmm will look into this. Are you doing a Ajax call? Maybe I can check if the request is Ajax, if so, I'll leave the headers alone.

[awebartisan]

Yes. Ajax request using Axios.

…

On Mon, 7 Jan 2019, 12:06 Tyler King ***@***.*** wrote: Hmm will look into this. Are you doing a Ajax call? Maybe I can check if the request is Ajax, if so, I'll leave the headers alone. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#164 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AbwdRp5uHPvxIl5grZQB-Te72Vz9YEE6ks5vAvIFgaJpZM4ZyZ28> .

[gnikyt]

Great! I think this will be a easy fix then :) stay tuned.

[gnikyt]

Commit above seems to solve the issue, will pend this for the next release, thanks!

[reijovosu]

I have same issue and this is still giving same error. Withaout middleware it is working

[gnikyt]

Are you using the release I just issued out? I have a check in there for Ajax requests

[reijovosu]

Yes I am using.

I fount that React fetch needs to include "X-Requested-With": "XMLHttpRequest" headers. Otherwise ajax() function returns false

fetch("/this/is/url", {
            credentials: "include",
            withCredentials: true,
            headers: {
                "Content-Type": "application/json",
                "X-Requested-With": "XMLHttpRequest"
            }
        })```

[gnikyt]

I'll add "wantsjson" method from laravel to it, that'll fix it

…

________________________________ From: reijovosu <notifications@github.com> Sent: Thursday, January 10, 2019 9:07:29 AM To: ohmybrew/laravel-shopify Cc: Tyler King; State change Subject: Re: [ohmybrew/laravel-shopify] application/json header in auth.shop middleware (#164) Yes I am using. I fount that React fetch needs to include "X-Requested-With": "XMLHttpRequest" headers. Otherwise ajax() function returns false fetch("/this/is/url", { credentials: "include", withCredentials: true, headers: { "Content-Type": "application/json", "X-Requested-With": "XMLHttpRequest" } }) — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub<#164 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ACTuOiCFyCdZSa6ITuZiZMXfjupIL6vGks5vBzQJgaJpZM4ZyZ28>.

[gnikyt]

Solved in v5.1.1 @reijovosu It will now check the content type.

[ericnkatz]

@ohmybrew this looks like its still not quite right.

Using the auth.shop middleware returning something like the following in a controller:
return response()->json(Model::all());

Yields a response that is text/html; charset=UTF-8 but looks like

HTTP/1.1 200 OK
Cache-Control: no-cache, private
Content-Type:  application/json
Date:          Fri, 25 Jan 2019 05:39:47 GMT

[]