Fix build on Kernel v. 6.12 #86
Conversation
`asm/unaligned.h` has been moved to `linux/unaligned.h` since Linux v. 6.12. C.f. e.g. torvalds/linux@5f60d5f
|
unfortunately this breaks the build on previous kernels, should try to make this change conditional like this: vendor-reset/src/amd/amdgpu/atom.c Line 43 in 084881c |
…so the module builds for both kernels below 6.12 and above. Thanks, @VoodaGod! Co-authored-by: Jason Rensburger <l33tjas.0n@gmail.com>
|
@VoodaGod I'm currently out of town, so I've just applied you suggestion through the GitHub mobile interface. I hope that's okay like this. Thanks! Note: I havent tested this myself yet. I should be able to until friday. |
|
For completeness' sake: I've also tested building the module with some older Kernels through my NixOS config and had no issues. I didn't switch to these Kernels and test the functionality, but as there haven't been many logic related changes in the recent past (and I've used the module through multiple of these older Kernel versions myself), I don't anticipate any problems in that regard. |
`asm/unaligned.h` has been moved to `linux/unaligned.h` since Linux v. 6.12 [^1]. This has broken the build for `vendor-reset` on newer versions. I've opened a PR with the upstream project [^2], but that has been sitting unmerged on GitHub for a while now, so I decided to add the fix temporarily using `fetchpatch` in the NixOS module for now. When it will (hopefully) eventually be merged, we should be able to remove the patch and just switch to an up-to-date upstream version. [^1]: torvalds/linux@5f60d5f [^2]: gnif/vendor-reset#86
`asm/unaligned.h` has been moved to `linux/unaligned.h` since Linux v. 6.12 [^1]. This has broken the build for `vendor-reset` on newer versions. I've opened a PR with the upstream project [^2], but that has been sitting unmerged on GitHub for a while now, so I decided to add the fix temporarily using `fetchpatch` in the NixOS module for now. When it will (hopefully) eventually be merged, we should be able to remove the patch and just switch to an up-to-date upstream version. [^1]: torvalds/linux@5f60d5f [^2]: gnif/vendor-reset#86
`asm/unaligned.h` has been moved to `linux/unaligned.h` since Linux v. 6.12 [^1]. This has broken the build for `vendor-reset` on newer versions. I've opened a PR with the upstream project [^2], but that has been sitting unmerged on GitHub for a while now, so I decided to add the fix temporarily using `fetchpatch` in the NixOS module for now. When it will (hopefully) eventually be merged, we should be able to remove the patch and just switch to an up-to-date upstream version. [^1]: torvalds/linux@5f60d5f [^2]: gnif/vendor-reset#86
`asm/unaligned.h` has been moved to `linux/unaligned.h` since Linux v. 6.12 [^1]. This has broken the build for `vendor-reset` on newer versions. I've opened a PR with the upstream project [^2], but that has been sitting unmerged on GitHub for a while now, so I decided to add the fix temporarily using `fetchpatch` in the NixOS module for now. When it will (hopefully) eventually be merged, we should be able to remove the patch and just switch to an up-to-date upstream version. [^1]: torvalds/linux@5f60d5f [^2]: gnif/vendor-reset#86
|
Kernel 6.12 made it into Debian Stable backports. Had to manually edit the DKMS source for now, can confirm this PR fixes the issue and works for both >=6.12 and <=6.11 kernels. |
asm/unaligned.hhas been moved tolinux/unaligned.hsince Linux v. 6.12 1, which breaks the build ofvendor-resete.g. on NixOS unstable (and likely other distributions, as soon as those switch to 6.12, too).On my system, the build fails with this error:
Footnotes
https://github.com/torvalds/linux/commit/5f60d5f6bbc12e782fac78110b0ee62698f3b576 ↩