Both Wayland desktops support win:allowResize and win:borderless #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing borderless functionality to libdecor_shellInit when win:borderless is set to true This works properly when going full screen as well
Added missing resizable functionality to xdg_shellInit when win:allowResize is set to true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libdecor_shellInitwas handlingwin:allowResizebut ignoringwin:borderless, so it did nothing on compositors using libdecor, for example GNOME/MutterConversely,
xdg_shellInitwas handlingwin:borderlessbut ignoringwin:allowResize, so it did nothing on compositors using the XDG shell protocol, for example KDE/Kwin, and many othersThis Pull Request fixes both issues and now both options work fine on different Wayland compositors.