Skip to content

fix cut, copy and paste for OSX bindings #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2016

Conversation

apicellaj
Copy link
Contributor

This is a quick fix to allow cut, copy and paste for OS X related to #156. This fix passes the standardized test of copying Welcome to ginger and pasting it into the address bar. Can anyone else running OS X verify this works for them?

I replaced the Action Pool copy method because it was failing in certain cases. Does this change cause any issues for anybody else?

I have a better idea how to improve this (and include Select All) but it might require a significant overhaul and seems to only be an issue for OS X anyway, right?

@hrj
Copy link
Member

hrj commented Jan 31, 2016

@atiqsayyed @bogas04 Please review / test if possible.

@bogas04
Copy link
Contributor

bogas04 commented Jan 31, 2016

Works fine for me. I think you should check it on other platforms too for proper integration @hrj

hrj added a commit that referenced this pull request Jan 31, 2016
fix cut, copy and paste for OSX bindings
@hrj hrj merged commit 716146c into gngrOrg:master Jan 31, 2016
@hrj
Copy link
Member

hrj commented Jan 31, 2016

Thanks @apicellaj and @bogas04. It works fine for me too on Linux + GTK.

I have a better idea how to improve this (and include Select All) but it might require a significant overhaul and seems to only be an issue for OS X anyway, right?

I am not fully into this code right now, but I have a vague memory that there are two action contexts. One context is for native input widgets such as text-boxes, etc. And one for the non-focussed case, which applies to the rendered page as a whole. Select-All (Ctrl-A) works for me in the input widgets, but not in the rendered page context. (This is on Linux + GTK)

@apicellaj If you have better ideas they are very welcome.

@apicellaj apicellaj deleted the feat-OSXbindings branch January 31, 2016 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants