border-*-width doesn't have default value

[hrj]

For the following style,

div {
  border-bottom-style: solid;
  border-bottom-color: green;
}

A border-bottom-width of 1px should be assumed.

Currently, it becomes 0px.

Need to check where the default needs to be decided (css parser, render-state or layout)

[hrj]

Test case here

jStyleParser is not inferring the border-*-width property. Will report upstream.

[hrj]

Added a comment to radkovo/jStyleParser#16

[hrj]

There is no response from upstream yet. We can implement this in gngr itself.

@bogas04 Do you want to take a shot at it?

It requires changes in the class HtmlValues. It has a method called getBorderInfo which needs to automatically infer missing values for border-width, when other border values are specified.

[hrj]

On second thoughts, from a design perspective, it might be cleaner to do the inference in the caller of getBorderInfo which is StyleSheetRenderState.

[bogas04]

Sure! Thanks for the location, will work on it tonight.

On 21-Oct-2015, at 11:20 AM, hrj notifications@github.com wrote:

There is no response from upstream yet. We can implement this in gngr itself.

@bogas04 Do you want to take a shot at it?

It requires changes in the class HtmlValues. It has a method called getBorderInfo which needs to automatically infer missing values for border-width, when other border values are specified.

—
Reply to this email directly or view it on GitHub.

[bogas04]

I was looking where the default border width was defined, and I came across this commented part of the code. Do you think it was intended to serve the same purpose ?

[hrj]

@bogas04 Yes, that might be relevant code. To be extra sure, you can try running the tests from grinder. I am going offline now but will be back later in the night, if you face any problems.

[hrj]

I fixed this in f1db56b

Didn't wait because it was affecting a lot of tests (44).

[bogas04]

Sorry for being inactive, final sem exams upcoming and the old code wasn't keeping me interested enough. Still new to much of the codebase of gngr, much to explore and learn!