Java 11 Fixes #199
Merged
Java 11 Fixes #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
katherine-hough
commented
Jul 21, 2023
katherine-hough
commented
- Removed double declaration of compiler plugin from aggregator POM.
- Factored packing of Phosphor into java.base module out of PhosphorJLinkPlugin into new class PhosphorPacker.
- Factored patching of Phosphor class from Instrumenter into new class PhosphorPatcher.
- Fixed issue with missing Unsafe#put/getReference methods in Java 11 causing JVM to crash.
- Fixed issue with intrinsic Unsafe#put/getObject methods in Java 11 causing JVM to crash.
- Fixed circular class loading in Java 11 from use of ConcurrentHashMap in BasicSourceSinkManager.
- Fixed tag loss related to VarHandles in Java 11 by patching the descriptor for the frame's hash.
- Added Java 11 to GHA workflow matrix.
- Increased version of checkout action in GHA workflow to v3.
- Added no -ntp (--no-transfer-progress) flag to maven commands in GHA workflow.
- Fixed issue with Phosphor wrapper argument not being cleared for null values resulting in old values being passed.
* Refactored JLink packaging and Phosphor class patching into its * Removed double declaration of compiler plugin from pom.xml * Factored packing of Phosphor into java.base module out of PhosphorJLinkPlugin into new class PhosphorPacker * Factored patching of Phosphor class from Instrumenter into new class PhosphorPatcher * Added Java 11 to workflows
… the method name and a lower part corresponding to the return-less descriptor * Fixed tag loss related to VarHandles in Java 11 by patching the descriptor for the frame's hash (lower part)
… the method name and a lower part corresponding to the return-less descriptor * Fixed tag loss related to VarHandles in Java 11 by patching the descriptor for the frame's hash (lower part)
* Added no -ntp (--no-transfer-progress) flag to maven commands in GHA workflow. * Fixed issue with Phosphor wrapper argument not being cleared for null values resulting in old values being passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.